Add back Python 3.8 Support #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please explain the changes you made here.
In #10, I discovered that this package was not compatible with Python 3.12, because it used
pkg_resources. Instead I usedimportlib.metadataand for some reason thought this was only compatible with Python 3.9 and higher. However this is not the case,importlib.metadatais available in the standard library starting in Python 3.8.This PR corrects that by:
importlib-metadatafrom the package dependencies (not necessary)setup.pyPython 3.7 will still not be supported.
Does this close any currently open issues?
No
Checklist: