Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote google/protobuf/api.proto as a runtime proto #3187

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

oldergod
Copy link
Member

@oldergod oldergod commented Nov 26, 2024

this includes its dependencies. This is useful for people who want to define a path on their RPCs without having to load protobuf on their proto path manually.

this includes its dependencies. This is useful for people who want to define a path on their RPCs.
Copy link
Collaborator

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what this means but if you want a green checkmark I am your guy

@oldergod
Copy link
Member Author

oldergod commented Nov 27, 2024

Protobuf exposes option so that someone can embed the path of an RPC in the proto schema like so

  rpc MyRpc (MyRequest) returns (MyResponse) {
    option (google.api.http) = {
      post: "/cash/my-path"
    };
  }

Before this PR, people wanting to use this option would have to manually add google/protobuf/api.proto to their path. After the PR, Wire does it by default.

@oldergod oldergod merged commit 06e7597 into master Nov 27, 2024
11 checks passed
@oldergod oldergod deleted the bquenaudon.2024-11-26.apiprotos branch November 27, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants