Skip to content

Commit

Permalink
Fix #40: New Version Notification doesn't post.
Browse files Browse the repository at this point in the history
Why:

* The old apps won't correctly post that there is a new version of the
  app unless there are no notifications in the Mac User Notification
  Center.

This change addresses the need by:

* Fix a backwards logic operator (i.e. '!=' -> '==').
* Release version 1.0.1.
  • Loading branch information
squaresurf committed Jan 14, 2016
1 parent bcd641a commit bbe5397
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 3 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## [Unreleased]

## [1.0.1]
### Fixed
- [Issue #40](https://github.com/squaresurf/objective-octocat-notifications/issues/40): New Version Notification doesn't post.

## [1.0.0]
### Added
- a CHANGELOG.md!!!
Expand All @@ -13,5 +17,6 @@ This project adheres to [Semantic Versioning](http://semver.org/).
- [Issue #38](https://github.com/squaresurf/objective-octocat-notifications/issues/38): Multiple Github status notifications.


[Unreleased]: https://github.com/squaresurf/objective-octocat-notifications/compare/1.0.0...HEAD
[Unreleased]: https://github.com/squaresurf/objective-octocat-notifications/compare/1.0.1...HEAD
[1.0.1]: https://github.com/squaresurf/objective-octocat-notifications/compare/1.0.0...1.0.1
[1.0.0]: https://github.com/squaresurf/objective-octocat-notifications/compare/0.4.0...1.0.0
2 changes: 1 addition & 1 deletion objective-octocat-notifications/AFGithubClientNoAuth.m
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ + (void)checkForNewRelease
for (NSUserNotification *notification in macNotifications) {
NSNumber *notificationType = [[notification userInfo] valueForKey:@"type"];

if ([notificationType unsignedLongValue] != OonMacNotificationForAppVersionCheck) {
if ([notificationType unsignedLongValue] == OonMacNotificationForAppVersionCheck) {
newVersionNotification = notification;
break;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>1.0.0</string>
<string>1.0.1</string>
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleURLTypes</key>
Expand Down

0 comments on commit bbe5397

Please sign in to comment.