Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintenance: remove HERE #1972

Closed
wants to merge 4 commits into from
Closed

Maintenance: remove HERE #1972

wants to merge 4 commits into from

Conversation

kinkie
Copy link
Contributor

@kinkie kinkie commented Dec 28, 2024 •
edited by rousskov
Loading

HERE has been deprecated for a while; there is only
one remaining instance of it.

rousskov
rousskov requested changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this cleanup.

src/debug/Stream.h Outdated Show resolved Hide resolved
@rousskov rousskov added the S-waiting-for-author author action is expected (and usually required) label Dec 29, 2024
yadij
yadij previously approved these changes Dec 29, 2024
View reviewed changes
@yadij @rousskov
Update src/debug/Stream.h
e0c62da 
Co-authored-by: Alex Rousskov <[email protected]>
@yadij yadij requested a review from rousskov December 29, 2024 06:08
@yadij yadij added S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box and removed S-waiting-for-author author action is expected (and usually required) labels Dec 29, 2024
rousskov
rousskov approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is more to say about MYNAME macro (mis)use, but I cannot polish this further now, and the current PR code is OK.

@rousskov rousskov added S-waiting-for-author author action is expected (and usually required) and removed S-waiting-for-reviewer ready for review: Set this when requesting a (re)review using GitHub PR Reviewers box labels Dec 29, 2024
@kinkie
Copy link
Contributor Author

kinkie commented Dec 29, 2024

Thanks @rousskov and @yadij

@kinkie kinkie added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels and removed S-waiting-for-author author action is expected (and usually required) labels Dec 29, 2024
squid-anubis pushed a commit that referenced this pull request Dec 31, 2024
@kinkie @squid-anubis
Maintenance: remove HERE (#1972)
e66b20c 
HERE has been deprecated for a while; there is only
one remaining instance of it.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Dec 31, 2024
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Dec 31, 2024
@kinkie kinkie mentioned this pull request Dec 31, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yadij yadij yadij approved these changes

@rousskov rousskov rousskov approved these changes

Assignees
No one assigned
Labels
M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kinkie @rousskov @yadij @squid-anubis