Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 5481: Fix GCC v14 build [-Wmaybe-uninitialized] #1982

Conversation

rousskov
Copy link
Contributor

Successful xstrtoui(start,end) calls do initialize end, but we can
polish this code and avoid triggering that GCC warning at the same time.

Successful xstrtoui(start,end) calls do initialize `end`, but we can
polish this code and avoid triggering that GCC warning at the same time.
@rousskov
Copy link
Contributor Author

N.B. -Wmaybe-uninitialized is enabled by -Wall in optimized builds.

Disclaimer: I do not have convenient access to GCC v14 at this time and cannot reproduce this warning with earlier GCC versions.

@rousskov rousskov added the S-waiting-for-more-reviewers needs a reviewer and/or a second opinion label Jan 14, 2025
@yadij yadij added M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels backport-to-v6 maintainer has approved these changes for v6 backporting and removed S-waiting-for-more-reviewers needs a reviewer and/or a second opinion labels Jan 14, 2025
squid-anubis pushed a commit that referenced this pull request Jan 15, 2025
Successful xstrtoui(start,end) calls do initialize `end`, but we can
polish this code and avoid triggering that GCC warning at the same time.
@squid-anubis squid-anubis added the M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels label Jan 15, 2025
@squid-anubis squid-anubis added M-merged https://github.com/measurement-factory/anubis#pull-request-labels and removed M-waiting-staging-checks https://github.com/measurement-factory/anubis#pull-request-labels M-cleared-for-merge https://github.com/measurement-factory/anubis#pull-request-labels labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v6 maintainer has approved these changes for v6 backporting M-merged https://github.com/measurement-factory/anubis#pull-request-labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants