fix cutsom button violation in properties table

Signed-off-by: srikant <[email protected]>
srikant-ch5 · Jan 21, 2025 · fc8fc7c · fc8fc7c
1 parent d2b3ba1
commit fc8fc7c
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/canvas_modules/common-canvas/locales/common-properties/locales/en.json b/canvas_modules/common-canvas/locales/common-properties/locales/en.json
@@ -95,6 +95,7 @@
   "table.toolbar.button.delete": "Delete",
   "table.toolbar.button.edit": "Edit",
   "table.toolbar.button.cancel": "Cancel",
+  "table.toolbar.overflow.label": "Table Toolbar Overflow",
   "list.table.label": "Values",
   "dropdown.tooltip.openMenu": "Open menu",
   "dropdown.tooltip.closeMenu": "Close menu",

diff --git a/...as_modules/common-canvas/src/common-properties/components/table-buttons/table-buttons.jsx b/...as_modules/common-canvas/src/common-properties/components/table-buttons/table-buttons.jsx
@@ -113,6 +113,7 @@ class TableButtons extends React.Component {
 				instanceId={0}
 				size="sm"
 				toolbarActionHandler={this.customButtonOnClick}
+				additionalText={{ overflowMenuLabel: this.props.toolbarOverflowLabel }}
 			/>
 		</div>);
 	}
@@ -123,6 +124,7 @@ TableButtons.propTypes = {
 	propertyId: PropTypes.object.isRequired,
 	customButtons: PropTypes.array.isRequired,
 	tableState: PropTypes.string,
+	toolbarOverflowLabel: PropTypes.string,
 	customButtonsState: PropTypes.object // set in by redux
 };
 

diff --git a/canvas_modules/common-canvas/src/common-properties/constants/constants.js b/canvas_modules/common-canvas/src/common-properties/constants/constants.js
@@ -127,6 +127,7 @@ export const MESSAGE_KEYS = {
 	TABLE_TOOLBAR_BUTTON_DELETE: "table.toolbar.button.delete",
 	TABLE_TOOLBAR_BUTTON_EDIT: "table.toolbar.button.edit",
 	TABLE_TOOLBAR_BUTTON_CANCEL: "table.toolbar.button.cancel",
+	TABLE_TOOLBAR_OVERFLOW_LABEL: "table.toolbar.overflow.label",
 	TABLE_DELETEICON_TOOLTIP: "table.deleteIcon.tooltip"
 
 };

diff --git a/canvas_modules/common-canvas/src/common-properties/controls/abstract-table.jsx b/canvas_modules/common-canvas/src/common-properties/controls/abstract-table.jsx
@@ -143,6 +143,11 @@ export default class AbstractTable extends React.Component {
 		return row;
 	}
 
+	// Returns the label for the overflow menu in the table toolbar
+	getTableToolbarOverflowLabel() {
+		return PropertyUtils.formatMessage(this.props.controller.getReactIntl(), MESSAGE_KEYS.TABLE_TOOLBAR_OVERFLOW_LABEL);
+	}
+
 	setScrollToRow(row) {
 		this.scrollToRow = row;
 	}
@@ -534,6 +539,7 @@ export default class AbstractTable extends React.Component {
 					tableState={tableState}
 					customButtons={customButtons}
 					customButtonsState={this.props.tableButtons}
+					toolbarOverflowLabel={this.getTableToolbarOverflowLabel()}
 				/>
 			</div>);
 		}