Skip to content

Commit

Permalink
Merge pull request #124 from srleecode/17.2.10
Browse files Browse the repository at this point in the history
fix: removed component being added when creating a library
  • Loading branch information
srleecode authored Jan 6, 2024
2 parents b2e5b8c + bb0e948 commit 34b0379
Show file tree
Hide file tree
Showing 5 changed files with 19 additions and 5 deletions.
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@srleecode/domain",
"version": "17.2.9",
"version": "17.2.10",
"private": true,
"description": "Nrwl nx plugin to allow operations at the domain level",
"homepage": "https://github.com/srleecode/domain",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,17 @@ describe('createPresentationLayerGenerator', () => {
eslint.overrides[0].rules['@angular-eslint/directive-selector'][1].prefix,
).toBe(prefix);
});

it('should should remove comopnent that is added by default to the library', async () => {
await createPresentationLayerGenerator(tree, {
...commonLibraryOptions,
groupingFolder,
});
expect(
tree.children(
`${groupingFolder}presentation/src/lib/test-app-test-domain-presentation`,
).length,
).toBe(0);
});
describe('eslint layer rules', () => {
beforeEach(() => {
const json = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@ export const addDomainLibrary = async (
throw e;
});
}
const libraryFolder = `${groupingFolderPath}/${libraryCommonOptions.name}/src/lib`;
tree
.children(libraryFolder)
.forEach((folder) => tree.delete(`${libraryFolder}/${folder}`));
const dasherisedGroupingFolder = getDasherizedFolderPath(
tree,
groupingFolderPath,
Expand Down
2 changes: 1 addition & 1 deletion packages/domain/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@srleecode/domain",
"version": "17.2.9",
"version": "17.2.10",
"main": "index.js",
"executors": "./executors.json",
"generators": "./generators.json",
Expand Down

0 comments on commit 34b0379

Please sign in to comment.