Merge pull request #356 from j5api/float-int-piezo

Allow Piezo.buzz to use int and float

j5/components/piezo.py

@@ -68,8 +68,14 @@ def identifier(self) -> int:
         """An integer to identify the component on a board."""
         return self._identifier
 
-    def buzz(self, duration: timedelta, pitch: Pitch) -> None:
-        """Queue a note to be played."""
+    def buzz(self, duration: Union[int, float, timedelta], pitch: Pitch) -> None:
+        """
+        Queue a note to be played.
+
+        Float and integer durations are measured in seconds.
+        """
+        if isinstance(duration, float) or isinstance(duration, int):
+            duration = timedelta(seconds=duration)
         if type(pitch) is int:
             pitch = float(pitch)
 

tests/components/test_piezo.py

@@ -44,6 +44,8 @@ def test_piezo_buzz_method() -> None:
     piezo.buzz(timedelta(seconds=1), 2093)
     piezo.buzz(timedelta(seconds=1), 2093.23)
     piezo.buzz(timedelta(minutes=1), Note.D7)
+    piezo.buzz(4, 2093)
+    piezo.buzz(4.3, 2093)
 
 
 def test_piezo_buzz_invalid_value() -> None:
@@ -55,8 +57,6 @@ def test_piezo_buzz_invalid_value() -> None:
         piezo.buzz(timedelta(seconds=1), "j5")  # type: ignore
     with pytest.raises(ValueError):
         piezo.buzz(timedelta(seconds=-2), Note.D7)
-    with pytest.raises(TypeError):
-        piezo.buzz(1, Note.D7)  # type: ignore
 
 
 def test_note_reversed() -> None: