Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove i argument in flip boilerplate code #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

obadakhalili
Copy link

flips spec function doesn't specify a second argument i, and the same is true for np.flip, which has a second argument to specify the dim to be flipped and it isn't applicable here since the requirement is only to support vectors.

So either the flip boilerplate code has to be updated, or the spec function. I can change other files if necessary.

@obadakhalili
Copy link
Author

It is worth noting that the same problem is in diff. The boilerplate code specifies an i argument but the spec code and the numpy example don't have this i argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant