remove all uses of encodeEntities (github#34202)

ssyberg · Jan 26, 2023 · 49dd50b · 49dd50b
1 parent 6b2e628
commit 49dd50b
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 17 deletions.
diff --git a/lib/render-content/README.md b/lib/render-content/README.md
@@ -30,7 +30,6 @@ Liquid will be looking for includes in `${process.cwd()}/includes`.
 
 Options:
 
-- `encodeEntities`: Encode html entities. Default: `false`.
 - `fileName`: File name for debugging purposes.
 - `textOnly`: Output text instead of html using [cheerio](https://ghub.io/cheerio).
 

diff --git a/lib/render-content/renderContent.js b/lib/render-content/renderContent.js
@@ -1,6 +1,6 @@
 import liquid from './liquid.js'
 import cheerio from 'cheerio'
-import { encode, decode } from 'html-entities'
+import { decode } from 'html-entities'
 import stripHtmlComments from 'strip-html-comments'
 import createProcessor from './create-processor.js'
 
@@ -50,10 +50,6 @@ async function renderContent(template = '', context = {}, options = {}) {
       html = fastTextOnly(html)
     }
 
-    if (options.encodeEntities) {
-      html = encode(html)
-    }
-
     return html.trim()
   } catch (error) {
     if (options.filename) {

diff --git a/tests/linting/lint-files.js b/tests/linting/lint-files.js
@@ -983,7 +983,6 @@ describe('lint learning tracks', () => {
               typeof entry.featured_track === 'boolean' ||
               (await renderContent(entry.featured_track, context, {
                 textOnly: true,
-                encodeEntities: true,
               })) === 'true'
             featuredTracksPerVersion.push(isFeaturedLink)
           }

diff --git a/tests/rendering/sidebar.js b/tests/rendering/sidebar.js
@@ -128,7 +128,7 @@ describe('sidebar', () => {
 
     // Create a ContentCheck object that has all the categories/subcategories and get the title from frontmatter
     async function createContentCheckDirectory() {
-      const renderOpts = { textOnly: true, encodeEntities: true }
+      const renderOpts = { textOnly: true }
 
       for (const filename of contentFiles) {
         const { data } = frontmatter(await fs.promises.readFile(filename, 'utf8'))

diff --git a/tests/unit/render-content.js b/tests/unit/render-content.js
@@ -98,15 +98,6 @@ describe('renderContent', () => {
     expect(output).toBe('')
   })
 
-  test('encodes entities', async () => {
-    const template = '<beep></beep>'
-    const context = {}
-    const output = await renderContent(template, context, {
-      encodeEntities: true,
-    })
-    expect(output).toBe('&lt;p&gt;&lt;beep&gt;&lt;/beep&gt;&lt;/p&gt;')
-  })
-
   test('does not render newlines around links in tables', async () => {
     const template = nl(`
 | Keyboard shortcut | Description