Fix how URL concatenation works #419
Merged
+51
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
N2D4
approved these changes
Feb 9, 2025
Co-authored-by: Konsti Wohlwend <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| @@ -12,8 +13,8 @@ export function isValidUrl(url: string) { | |||
| return !!createUrlIfValid(url); | |||
| } | |||
|
|
|||
| export function isLocalhost(urlOrString: string | URL) { | |||
| const url = createUrlIfValid(urlOrString); | |||
| export function isLocalhost(urlOrString: URL | string | null | undefined) { ; | |||
There was a problem hiding this comment.
Remove the stray semicolon after the function opening. Also, consider adding a brief comment on why the function now accepts null/undefined.
Suggested change
| export function isLocalhost(urlOrString: URL | string | null | undefined) { ; | |
| export function isLocalhost(urlOrString: URL | string | null | undefined) { |
N2D4
reviewed
Feb 11, 2025
| export function isLocalhost(urlOrString: string | URL) { | ||
| const url = createUrlIfValid(urlOrString); | ||
| export function isLocalhost(urlOrString: URL | string | null | undefined) { ; | ||
| const url = typeof urlOrString === "string" ? createUrlIfValid(urlOrString) : urlOrString; |
There was a problem hiding this comment.
reverted it to its original implementation, my branch had a broken implementation for some reason before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Replaces URL concatenation with
urlStringtemplate literal tag inStackServerInterfacefor improved URL handling and encoding.urlStringtemplate literal tag inStackServerInterfacemethods for encoding values.getServerUserById,listServerTeamInvitations, andrevokeServerTeamInvitation.urlStringfunction inurls.tsxfor URL string creation with encoding.templateIdentityinstrings.tsxto simplify string concatenation logic.process-css.tsto use template literals forglobalCSSexport.This description was created by
for 31d071b. It will automatically update as commits are pushed.