Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Andrews todo #632

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Andrews todo #632

wants to merge 1 commit into from

Conversation

HPCurtis
Copy link

Remove for loop around the abs function now the abs function has been vectorised since 2.30

@HPCurtis
Copy link
Author

Very interested in how this failed as the model compiles fine and the issue is arising on the install of the rstanarm package.

jgabry
jgabry approved these changes Sep 27, 2024
View reviewed changes
Copy link
Member

@jgabry jgabry left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I don't think this is failing due to anything you did, sometimes we've had problems with rstanarm installation on GitHub actions for reasons that, to be honest, I don't always understand. Your changes to the code look good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgabry jgabry jgabry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HPCurtis @jgabry