Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): TE-2414 upgrade axios version #1549

Merged
merged 1 commit into from
Oct 4, 2024
Merged

chore(ui): TE-2414 upgrade axios version #1549

merged 1 commit into from
Oct 4, 2024

Conversation

nalin-patidar
Copy link
Collaborator

Issue(s)

https://startree.atlassian.net/browse/TE-2414

Description

Upgrade axios version to fix snyk vulnerability

@nalin-patidar nalin-patidar requested review from a team as code owners September 10, 2024 08:03
Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdeye ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 8:05am

@github-actions github-actions bot added the thirdeye-ui config Updates to thirdeye-ui project configuration label Sep 10, 2024
@@ -64,7 +64,7 @@
"@tanstack/react-query": "^4.29.19",
"@tippyjs/react": "^4.2.6",
"@visx/visx": "3.1.2",
"axios": "1.3.4",
"axios": "^1.7.4",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use exact version without ^

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using the packacge.lock file and checking it out in source control too. Also we are using npm CI everywhere.
So we should be good with carat I think.

@nalin-patidar nalin-patidar merged commit c39adad into master Oct 4, 2024
12 checks passed
@nalin-patidar nalin-patidar deleted the te-2414 branch October 4, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
thirdeye-ui config Updates to thirdeye-ui project configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants