Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): TE-2143 show saved investigations irrespective of feedback type #1552

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

nalin-patidar
Copy link
Collaborator

… type

Issue(s)

https://startree.atlassian.net/browse/TE-2143

Description

If the anomaly has any investigations, show them on the anomaly details page irrespective of there is feedback or not

Screenshots

Screenshot 2024-09-12 at 8 27 47 AM Screenshot 2024-09-12 at 8 28 05 AM Screenshot 2024-09-12 at 8 28 49 AM

@nalin-patidar nalin-patidar requested a review from a team as a code owner September 12, 2024 03:00
Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdeye ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2024 3:00am

@github-actions github-actions bot added the thirdeye-ui Updates to thirdeye-ui project label Sep 12, 2024
{t("label.duplicate")}
</Button>
</Grid>
<Box height="90vh">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we use % instead?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The datatable uses %. So at some level above we have to provide a fixed height for the % to derive its value from, which comes from the containing box

@nalin-patidar nalin-patidar merged commit 5acd02e into master Sep 12, 2024
12 checks passed
@nalin-patidar nalin-patidar deleted the te-2143 branch September 12, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
thirdeye-ui Updates to thirdeye-ui project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants