This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
IDE support: Convert Windows absolute filename arguments #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...to unix-style absolute paths. We don't touch paths outside the test-pack as we don't know how to map them into the docker-container. We don't touch relative paths inside the test-pack because we don't have a reliable heuristic to identify them. This is useful for IDE integration. You can configure Eclipse to run `stbt-docker stbt lint $filename` or `stbt-docker stbt auto-selftest generate $filename`, but it won't make `$filename` relative to the test-pack route. We fix that by converting it here. I can think of one place where this heuristic will fail. An argument `--filename=c:\test-pack\tests\my_test.py` would not trigger rewriting. I'm sure there are others too.
wmanley
force-pushed
the
windows-convert-abs-paths
branch
from
b6bfa9e to
fe186a5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...to unix-style absolute paths.
We don't touch paths outside the test-pack as we don't know how to map them
into the docker-container. We don't touch relative paths inside the
test-pack because we don't have a reliable heuristic to identify them.
This is useful for IDE integration. You can configure Eclipse to run
stbt-docker stbt lint $filenameorstbt-docker stbt auto-selftest generate $filename, but it won't make$filenamerelative to the test-pack route. We fix that by converting ithere.
I can think of one place where this heuristic will fail. An argument
--filename=c:\test-pack\tests\my_test.pywould not trigger rewriting.I'm sure there are others too.
TODO:
os.path.isabsconsiders an absolute path on Windows