Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SecureWorkflow function to Handle Empty File input #2044

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Update SecureWorkflow function to Handle Empty File input #2044

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions remediation/workflow/permissions/permissions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ func AddWorkflowLevelPermissions(inputYaml string, addProjectComment bool) (stri
line := 0
column := 0
topNode := t.Content
if len(topNode) == 0 {
return inputYaml, fmt.Errorf("Workflow file provided is Empty")
}
for _, n := range topNode[0].Content {
if n.Value == "jobs" && n.Tag == "!!str" {
line = n.Line
Expand Down
1 change: 1 addition & 0 deletions remediation/workflow/secureworkflow_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ func TestSecureWorkflow(t *testing.T) {
{fileName: "nopin.yml", wantPinnedActions: false, wantAddedHardenRunner: true, wantAddedPermissions: true},
{fileName: "allperms.yml", wantPinnedActions: false, wantAddedHardenRunner: false, wantAddedPermissions: true},
{fileName: "multiplejobperms.yml", wantPinnedActions: false, wantAddedHardenRunner: false, wantAddedPermissions: true},
{fileName: "error.yml", wantPinnedActions: false, wantAddedHardenRunner: false, wantAddedPermissions: false},
}
for _, test := range tests {
input, err := ioutil.ReadFile(path.Join(inputDirectory, test.fileName))
Expand Down
Empty file added testfiles/secureworkflow/input/error.yml
View file
Open in desktop
Empty file.
Empty file added testfiles/secureworkflow/output/error.yml
View file
Open in desktop
Empty file.