Implement split element orders

[mo-jdendy]

Currently the function space object in LFRic has an argument element_order which dictates the polynomial order of the finite elements in the model. Alongside LFRic 4443 and LFRic Apps 358, this pull request begins to implement splitting of this argument into a horizontal order element_order_h and a vertical order element_order_v. This release will likely have to be coordinated with the LFRic release to avoid breakage.

To better understand this change and the reasoning behind it, please read the LFRic core ticket and attached guide to changes.

For now, the necessary infrastructure is added to the function space objects but the capability will remain locked by a clause in the file function_space_constructor_helper_functions_mod.F90 which does not allow for the horizontal and vertical element orders to differ from each other. A future LFRic ticket will fully enable the splitting but the change is too large for a single ticket.

The main changes here are:

• Occurrences of the function space getter get_fs will have the element_order argument swapped to element_order_h, element_order_v. The familiar zeroth order function space, for example, can now be generated by setting both element orders to be 0. This function space will behave identically to before, with the exception of some of the getters becoming orientation specific (such as get_ndof_face becoming get_ndof_face_h and get_ndof_face_v)
• Initialisations of the number of quadrature points now uses the formula nqp=MAX(element_order_h, element_order_v)+3 . This is temporary as we expect to split quadrature points in the horizontal and vertical for efficiency in the future.
• Other relevant PSyclone changes to Python scripts and tests which store element_order, for example in a dictionary.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.88%. Comparing base (2307ac7) to head (5dbc209).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2799   +/-   ##
=======================================
  Coverage   99.88%   99.88%           
=======================================
  Files         359      359           
  Lines       50833    50837    +4     
=======================================
+ Hits        50777    50781    +4     
  Misses         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[DrTVockerodtMO]

Some small comments re. copyright headers.

[mo-jdendy]

After testing this branch in the PSyclone test environment with LFRic apps ticket 358, it does appear to fix the failures in the adjoint tests and all tests in the developer suite pass.