Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disco cnv UI updates #2556

Merged
merged 4 commits into from
Jan 5, 2025
Merged

Disco cnv UI updates #2556

merged 4 commits into from
Jan 5, 2025

Conversation

creilly8
Copy link
Contributor

@creilly8 creilly8 commented Jan 3, 2025

Description

Closes issue #2555.

Minor changes:

  1. Removed cnv capping as a legend item
  2. The Unit row in the cnv tooltip is removed as the value is already present in the first row.

Test:

  1. GDC example
  2. PNET example

Checklist

Check each task that has been performed or verified to be not applicable.

  • Tests: added and/or passed unit and integration tests, or N/A
  • Todos: commented or documented, or N/A
  • Notable Changes: updated release.txt, prefixed a commit message with "fix:" or "feat:", added to an internal tracking document, or N/A

@creilly8 creilly8 requested review from xzhou82 and aacic January 3, 2025 16:14
@creilly8 creilly8 linked an issue Jan 3, 2025 that may be closed by this pull request
@xzhou82
Copy link
Collaborator

xzhou82 commented Jan 3, 2025

thanks, please also improve the gene hover tooltip. e.g. here and hover over PIK3CA

the tooltip should show following rows

  1. Gene: PIK3CA (remove the extra padding on left of gene name)
  2. Mutation: aachange consequence(in color) chr:pos
  3. Mutation: if gene has multiple mutations
  4. CNV: [colorbox] value chr:start-stop

no change to tooltip hovering on a mutation

@xzhou82 xzhou82 requested a review from congyu-lu January 3, 2025 16:37
@creilly8
Copy link
Contributor Author

creilly8 commented Jan 3, 2025

thanks, please also improve the gene hover tooltip. e.g. here and hover over PIK3CA

the tooltip should show following rows

  1. Gene: PIK3CA (remove the extra padding on left of gene name)
  2. Mutation: aachange consequence(in color) chr:pos
  3. Mutation: if gene has multiple mutations
  4. CNV: [colorbox] value chr:start-stop

no change to tooltip hovering on a mutation

@xzhou82. I don't quite understand. #1 and #4 were easy to fix but I don't know what you mean in #2 or #3. Do you want the Consequence row updated to Mutation? Are you also asking for all mutations to be listed in one row instead of individually?

@xzhou82 xzhou82 merged commit 5c8b61e into master Jan 5, 2025
3 checks passed
@xzhou82 xzhou82 deleted the issue.2555 branch January 5, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disco cnv improvement
2 participants