Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ensure all rulesets can be run in offline context #1015

Merged
merged 1 commit into from
Mar 15, 2020
Merged

chore: ensure all rulesets can be run in offline context #1015

merged 1 commit into from
Mar 15, 2020

Conversation

nulltoken
Copy link
Contributor

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

In order to prepare for json-schema-ref-parser, this PR should cover the "cover the execution of the oas2 and oas3 schema rules in offline context (in order to ensure calling bundle() against the generated static assets doesn't trigger any http call)." part of #923 (comment)

This PR also includes a test that will ensure newly added rulesets aren't overlooked.

@nulltoken nulltoken self-assigned this Mar 14, 2020
@nulltoken nulltoken requested review from P0lip and philsturgeon March 14, 2020 13:31
@P0lip P0lip merged commit c969a32 into stoplightio:develop Mar 15, 2020
@nulltoken nulltoken deleted the ntk/offline branch March 15, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants