Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo on space page #187

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix: typo on space page #187

merged 1 commit into from
Jan 16, 2025

Conversation

jamiechicago312
Copy link
Contributor

nitpick [non-blocking]:

Add an a.
A space is [a] decentralized bucket.

See image for original.
image

Added an a.
A space is [a] decentralized bucket.
Copy link
Contributor

Website preview 🔗✨

build log

@jamiechicago312
Copy link
Contributor Author

You can see the typo on this page if logged in: https://console.storacha.network/space/create

Copy link
Member

@volmedo volmedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@volmedo
Copy link
Member

volmedo commented Jan 16, 2025

about the failing check related to Conventional Commits, in case you are not familiar with that, it is, as its name implies, a convention to name commits where every commit message is prefixed by the kind of changes it is introducing. The prefix should give some hints about what the commit's goal is, i.e. whether it is introducing a new feature, or just introducing a fix, or refactoring some code.

In this specific case, you can just add a colon after the word fix: ... to make the check happy.

@jamiechicago312 jamiechicago312 changed the title fix typo on space page fix: typo on space page Jan 16, 2025
@jamiechicago312 jamiechicago312 merged commit 539f948 into main Jan 16, 2025
5 of 6 checks passed
@jamiechicago312 jamiechicago312 deleted the fix/typo-in-space-page branch January 16, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants