Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(providerindex): accept multiple legacy options #86

Draft
wants to merge 3 commits into
base: fix/claim-fallback-cid
Choose a base branch
from

Update pkg/service/providerindex/legacy.go

50df695
Select commit
Loading
Failed to load commit list.
Draft

refactor(providerindex): accept multiple legacy options #86

Update pkg/service/providerindex/legacy.go
50df695
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jan 14, 2025 in 0s

45.31% of diff hit (target 34.84%)

View this Pull Request on Codecov

45.31% of diff hit (target 34.84%)

Annotations

Check warning on line 171 in pkg/aws/service.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/aws/service.go#L169-L171

Added lines #L169 - L171 were not covered by tests

Check warning on line 188 in pkg/aws/service.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/aws/service.go#L188

Added line #L188 was not covered by tests

Check warning on line 186 in pkg/construct/construct.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/construct/construct.go#L186

Added line #L186 was not covered by tests

Check warning on line 188 in pkg/construct/construct.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/construct/construct.go#L188

Added line #L188 was not covered by tests

Check warning on line 342 in pkg/construct/construct.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/construct/construct.go#L342

Added line #L342 was not covered by tests

Check warning on line 347 in pkg/construct/construct.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/construct/construct.go#L347

Added line #L347 was not covered by tests

Check warning on line 40 in pkg/internal/testutil/mocks/mock_LegacyClaimsFinder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/internal/testutil/mocks/mock_LegacyClaimsFinder.go#L40

Added line #L40 was not covered by tests

Check warning on line 43 in pkg/internal/testutil/mocks/mock_LegacyClaimsFinder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/internal/testutil/mocks/mock_LegacyClaimsFinder.go#L43

Added line #L43 was not covered by tests

Check warning on line 51 in pkg/internal/testutil/mocks/mock_LegacyClaimsFinder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/internal/testutil/mocks/mock_LegacyClaimsFinder.go#L51

Added line #L51 was not covered by tests

Check warning on line 72 in pkg/internal/testutil/mocks/mock_LegacyClaimsFinder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/internal/testutil/mocks/mock_LegacyClaimsFinder.go#L72

Added line #L72 was not covered by tests

Check warning on line 74 in pkg/internal/testutil/mocks/mock_LegacyClaimsFinder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/internal/testutil/mocks/mock_LegacyClaimsFinder.go#L74

Added line #L74 was not covered by tests

Check warning on line 84 in pkg/internal/testutil/mocks/mock_LegacyClaimsFinder.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/internal/testutil/mocks/mock_LegacyClaimsFinder.go#L84

Added line #L84 was not covered by tests

Check warning on line 75 in pkg/service/providerindex/legacy.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/service/providerindex/legacy.go#L74-L75

Added lines #L74 - L75 were not covered by tests

Check warning on line 135 in pkg/service/providerindex/legacy.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/service/providerindex/legacy.go#L134-L135

Added lines #L134 - L135 were not covered by tests

Check warning on line 145 in pkg/service/providerindex/legacy.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/service/providerindex/legacy.go#L144-L145

Added lines #L144 - L145 were not covered by tests

Check warning on line 155 in pkg/service/providerindex/legacy.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/service/providerindex/legacy.go#L154-L155

Added lines #L154 - L155 were not covered by tests

Check warning on line 301 in pkg/service/providerindex/legacy.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/service/providerindex/legacy.go#L301

Added line #L301 was not covered by tests

Check warning on line 123 in pkg/service/service.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/service/service.go#L121-L123

Added lines #L121 - L123 were not covered by tests

Check warning on line 69 in tools/queryresult/genfixture.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tools/queryresult/genfixture.go#L69

Added line #L69 was not covered by tests

Check warning on line 81 in tools/queryresult/genfixture.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

tools/queryresult/genfixture.go#L81

Added line #L81 was not covered by tests