Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix overlapping shadow of testing module on scrollbar #30132

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Dec 24, 2024

Closes #

What I did

Fixed the overlaying box-shadow on the scrollbar
Bildschirmfoto 2024-12-24 um 10 56 07

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.8 MB 77.8 MB 0 B 1.46 0%
initSize 143 MB 143 MB 48 B 1.31 0%
diffSize 65.6 MB 65.6 MB 48 B 1.31 0%
buildSize 7.19 MB 7.19 MB 48 B -0.97 0%
buildSbAddonsSize 1.85 MB 1.85 MB 0 B -0.79 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.87 MB 1.87 MB 48 B 0.37 0%
buildSbPreviewSize 0 B 0 B 0 B - -
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.92 MB 3.92 MB 48 B -0.81 0%
buildPreviewSize 3.28 MB 3.28 MB 0 B -1 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 8.4s 20.2s 11.8s 1.18 58.4%
generateTime 26.8s 20.5s -6s -249ms -0.23 -30.4%
initTime 18.1s 14.8s -3s -321ms -0.16 -22.3%
buildTime 9.6s 9.9s 295ms 0.91 3%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 5.4s 6.4s 1s 1.11 15.8%
devManagerResponsive 3.7s 4.7s 989ms 1.15 20.7%
devManagerHeaderVisible 590ms 602ms 12ms -0.3 2%
devManagerIndexVisible 618ms 635ms 17ms -0.25 2.7%
devStoryVisibleUncached 2s 2.1s 185ms 0.53 8.5%
devStoryVisible 620ms 636ms 16ms -0.3 2.5%
devAutodocsVisible 560ms 554ms -6ms -0.09 -1.1%
devMDXVisible 523ms 511ms -12ms -0.47 -2.3%
buildManagerHeaderVisible 609ms 648ms 39ms 0.06 6%
buildManagerIndexVisible 703ms 731ms 28ms -0.04 3.8%
buildStoryVisible 595ms 622ms 27ms 0.09 4.3%
buildAutodocsVisible 491ms 467ms -24ms -0.31 -5.1%
buildMDXVisible 489ms 544ms 55ms 0.54 10.1%

Greptile Summary

Let me provide a clear and concise summary of the changes in this pull request.

Fixed overlapping shadow issue in the Storybook sidebar's bottom testing module by adjusting the Content component's styling in SidebarBottom.tsx.

  • Modified padding from 12 to '12px 0' to remove horizontal padding
  • Added margin: '0 12px' to maintain proper spacing
  • Added overflow: 'hidden' to prevent content from spilling outside container
  • Changes ensure testing module's shadow no longer overlaps with the scrollbar while maintaining existing functionality

The changes are focused purely on styling adjustments to fix a specific UI issue, with no functional changes to the component's behavior.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Dec 24, 2024

View your CI Pipeline Execution ↗ for commit 6814085.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 35s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-24 10:03:53 UTC

@valentinpalkovic valentinpalkovic merged commit 494cdc3 into next Dec 30, 2024
67 of 78 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-overlapping-shadow-on-scrollbar branch December 30, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant