-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/namespace tag #65
base: master
Are you sure you want to change the base?
Conversation
Awesome. I'll take a look at it more closely later tonight. |
Quick question: would the same namespace be something you'd want applied to every example or just a few? |
My use case right now will require it on every doc item so it could be declared at the project level (as global configuration) but I think it's better if they are defined individually at the doc item level, here's why:
Further to that I though it might be nice to show the namespace (when preset) in the UI as a small tag/label on each example. What are you thinking? |
I was just thinking that it might be tedious to remember to add the namespace to every example, otherwise your output is visually broken, but that's just me. The visual label would probably be a good indication of what's missing though, so that might do well as the reminder. |
We could have both options, global configuration optionally overridden at the example level? As for the label, I was thinking it would only show up if there was a namespace defined, primarily because I think the large majority of projects wont use them, it would be a distraction most of the time, but I could use the string "Global" when there is none so the namespace is always explicit (in the UI) (only becomes confusing if the creator actually uses a namespace called "Global"). The reminder would then be more for the users of the style guide, reminding them to include the namespace in any implementations that utilize the design system as apposed to the a reminder for the creators of the style guide itself. Does that change your mind about anything and how would you like me to proceed? |
👍 I like it. A global level would make maintaining the docs a bit easier, and having the ability to override it per example will make it more flexible. I like the visual label for the consumers. |
Here's what I came up with, I hope the data attribute is acceptable.