Add red highlight for profiles generating alerts #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no_client_ip_is_set' into alya/fix_profiler_crashing_when_no_client_ip_is_set # Conflicts: # config/slips.yaml # slips_files/core/profiler.py
|
Hey @AbhiramMasna Thanks for contributing! Can you tell me how did you test your changes? When i test them using the following command the IP 192.168.1.129 generates an alert, so i expect to see it marked in red, however it's not marked in red when i go to the web interface |
…_profiler_crashing_when_no_client_ip_is_set Support ip ranges in the client_ip param in slips.yaml
…rove_blacklisted_ips_detection Improve blacklisted ips detection
…_multiple_reconnection_attempts Fix problem setting multiple reconnection attempts evidence
…domain isnt found
…ect_SSL_Certificate_Name_Hostname_Mismatch Detect ssl certificate hostname mismatch
Bumps [psutil](https://github.com/giampaolo/psutil) from 6.0.0 to 6.1.1. - [Changelog](https://github.com/giampaolo/psutil/blob/master/HISTORY.rst) - [Commits](giampaolo/psutil@release-6.0.0...release-6.1.1) --- updated-dependencies: - dependency-name: psutil dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.6.8 to 0.8.4. - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](astral-sh/ruff@0.6.8...0.8.4) --- updated-dependencies: - dependency-name: ruff dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…ot/pip/install/develop/psutil-6.1.1 build(deps): bump psutil from 6.0.0 to 6.1.1 in /install
…ot/pip/install/develop/ruff-0.8.4 build(deps): bump ruff from 0.6.8 to 0.8.4 in /install
…k/AbhiramMasna/highlight-alerts
|
hello @AbhiramMasna i just tested your changes using the same steps above and i still dont get a red highlight for the 192.168.1.129 profile, did you test it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change addresses the issue where only the "timewindows" were highlighted in red for profiles generating alerts during PCAP analysis. To improve visibility and usability, the entire profile row is now marked in red if it generates an alert.
Why This Change Was Made:
Marking only the "timewindows" in red was insufficient for quickly identifying profiles linked to alerts. This enhancement makes it easier for users to locate and assess alert-generating profiles in the interface.
Changes Made:
Updated the tableDefs.js file to apply a red background color to the row of any profile that generates an alert.
Used the fnRowCallback function in the profiles table definition to apply the conditional formatting.