generated from stratosphereips/awesome-code-template
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Campaigns POC #38
Open
HolecekM
wants to merge
14
commits into
stratosphereips:campaigns
Choose a base branch
from
HolecekM:campaigns-kickoff
base: campaigns
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Campaigns POC #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGTM, I think it looks nice! |
…as the rest (null)
HolecekM
force-pushed
the
campaigns-kickoff
branch
from
December 17, 2024 00:04
35c7aee
to
7b35015
Compare
waiting for #37 to merge to prevent potential double rebases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/campaigns
) consists of steps, defined in itsmeta.json
enforce_order
, students can be disallowed from solving challenges and tasks out of ordershow_locked
, they can still at least be shown the challenges that they cannot solve yetGET /api/challenges
endpoint will NOT include ones that have this associationGET /api/campaigns
for a list of campaigns (without challenges, tasks and pages)GET /api/campaigns/:id
for one campaign detail including everything (including challenge running status)#campaign/:id
->CampaignDetail
- overview of the campaign#campaign/:cid/:sid
->CampaignStep
- either aChallengeDetail
or a rendered pageenforce_order && !show_locked
)This is a proof of concept, some documentation is missing and not everything is implemented - we are NOT merging into
main
butcampaigns
, where further development will take place.Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
run_tests.sh
Checklist:
eslint
and formatted it properly usingprettier
pylint
and formatted it properly usingautopep8