-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples,metrics,kube-state-metrics): add configmap and promethe… #10919
base: main
Are you sure you want to change the base?
Conversation
…us-rules In order to implement https://github.com/strimzi/proposals/blob/main/087-monitoring-of-custom-resources.md an initial version of the configmap and prometheus-rules are added for 'KafkaUser' and 'KafkaTopic' resources. Part of strimzi#10276 Signed-off-by: Sebastian Gaiser <[email protected]>
I'm unsure wehter |
At least in theory, all resources might have those. But I think for example KafkaTopic does not have anything deprecated right now. But I would have it covered for all resources and in the worst case, the alert will never be raised. If you don't add it now, we will likely forget to add it if we one day deprecate something there. |
Signed-off-by: Sebastian Gaiser <[email protected]>
packaging/examples/metrics/kube-state-metrics/prometheus-rules.yaml
Outdated
Show resolved
Hide resolved
….yaml Signed-off-by: Sebastian Gaiser <[email protected]>
@scholzj I added the |
packaging/examples/metrics/kube-state-metrics/prometheus-rules.yaml
Outdated
Show resolved
Hide resolved
….yaml Signed-off-by: Sebastian Gaiser <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. But it would be great to probably:
- Have some README.md file here explaining what this is and how to use it?
- Maybe we can add some simple chapter to the end of this section in the docs (https://strimzi.io/docs/operators/latest/full/deploying.html#assembly-metrics-str) that would at least mention this as well?
I had a first pass and agree with Jakub on what's missing. I will have another pass when the upgrades are committed. |
Signed-off-by: Sebastian Gaiser <[email protected]>
Signed-off-by: Sebastian Gaiser <[email protected]>
Signed-off-by: Sebastian Gaiser <[email protected]>
Signed-off-by: Sebastian Gaiser <[email protected]>
Signed-off-by: Sebastian Gaiser <[email protected]>
Signed-off-by: Sebastian Gaiser <[email protected]>
Signed-off-by: Sebastian Gaiser <[email protected]>
Signed-off-by: Sebastian Gaiser <[email protected]>
Signed-off-by: Sebastian Gaiser <[email protected]>
Signed-off-by: Sebastian Gaiser <[email protected]>
Signed-off-by: Sebastian Gaiser <[email protected]>
I've tried to address your points:
In addition I added a KSM deployment (similar as it already exists for Grafana) for clarifying how a Kubernetes deployment could look like. I've decided against the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
…us-rules
In order to implement https://github.com/strimzi/proposals/blob/main/087-monitoring-of-custom-resources.md an initial version of the configmap and prometheus-rules are added for 'KafkaUser' and 'KafkaTopic' resources.
Part of #10276
Type of change
Description
See commit message
Checklist
Please go through this checklist and make sure all applicable tasks have been done