Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(mm2): considerations for active/passive disaster recovery #10942

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

docs(mm2): considerations for active/passive disaster recovery #10942

wants to merge 2 commits into from

Conversation

PaulRMellor
Copy link
Contributor

@PaulRMellor PaulRMellor commented Dec 11, 2024 •
edited
Loading

Documentation

MirrorMaker 2 active/passive configuration.
Adds considerations and general best practices around disaster recovery

Checklist

Please go through this checklist and make sure all applicable tasks have been done

  • Write tests
  • Make sure all tests pass
  • Update documentation
  • Check RBAC rights for Kubernetes / OpenShift roles
  • Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
  • Reference relevant issue(s) and close them after merging
  • Update CHANGELOG.md
  • Supply screenshots for visual changes, such as Grafana dashboards

@PaulRMellor PaulRMellor added this to the 0.46.0 milestone Dec 11, 2024
@PaulRMellor PaulRMellor requested a review from mimaison December 11, 2024 17:33
@PaulRMellor PaulRMellor self-assigned this Dec 11, 2024
scholzj
scholzj approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit. But LGTM otherwise. Thanks.

documentation/modules/configuring/con-mm2-recovery.adoc Outdated Show resolved Hide resolved
@jcliffor
Copy link

@PaulRMellor Looks good. Just a few minor suggestions

@PaulRMellor
Copy link
Contributor Author

@PaulRMellor Looks good. Just a few minor suggestions

Thanks @jcliffor -- I've addressed the comments

katheris
katheris reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few questions around some of the wording that was unclear to me

documentation/modules/configuring/con-mm2-recovery.adoc Outdated Show resolved Hide resolved
documentation/modules/configuring/con-mm2-recovery.adoc Show resolved Hide resolved
documentation/modules/configuring/con-mm2-recovery.adoc Outdated Show resolved Hide resolved
@PaulRMellor
Copy link
Contributor Author

I had a few questions around some of the wording that was unclear to me

Thanks @katheris -- I've addressed your questions to try to make the text clearer.

katheris
katheris approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@katheris katheris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paul the changes look good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcliffor jcliffor jcliffor approved these changes

@katheris katheris katheris approved these changes

@scholzj scholzj scholzj approved these changes

@mimaison mimaison Awaiting requested review from mimaison

Assignees

@PaulRMellor PaulRMellor

Labels
documentation
Projects
None yet
Milestone
0.46.0
Development

Successfully merging this pull request may close these issues.
4 participants
@PaulRMellor @jcliffor @scholzj @katheris