-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PoC] Sentry client #4178
base: master
Are you sure you want to change the base?
[PoC] Sentry client #4178
Conversation
c79e86c
to
96a02d7
Compare
5 builds increased size, 1 build decreased size
StripeSize 1.0 (1)
|
Item | Install Size Change |
---|---|
🗑 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... | ⬇️ -1.9 kB |
📝 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... | ⬆️ 1.6 kB |
🗑 StripePayments.STPAPIClient.linkAccountSessions(endpoint,clientSe... | ⬇️ -1.2 kB |
📝 StripePayments.STPAPIClient.linkAccountSessions(endpoint,clientSe... | ⬆️ 936 B |
Other | ⬆️ 1.2 kB |
StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 2.4 kB (0.16%)
Total download size change: ⬆️ 559 B (0.13%)
Largest size changes
Item | Install Size Change |
---|---|
Other | ⬆️ 2.4 kB |
StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 2.8 kB (0.07%)
Total download size change: ⬆️ 1.1 kB (0.08%)
Largest size changes
Item | Install Size Change |
---|---|
Other | ⬆️ 2.8 kB |
StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 710 B (0.02%)
Total download size change: ⬇️ 262 B (-0.02%)
Largest size changes
Item | Install Size Change |
---|---|
🗑 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... | ⬇️ -1.9 kB |
📝 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... | ⬆️ 1.6 kB |
🗑 StripePayments.STPAPIClient.linkAccountSessions(endpoint,clientSe... | ⬇️ -1.2 kB |
📝 StripePayments.STPAPIClient.linkAccountSessions(endpoint,clientSe... | ⬆️ 936 B |
Other | ⬆️ 1.2 kB |
StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬆️ 712 B (0.01%)
Total download size change: ⬆️ 578 B (0.03%)
Largest size changes
Item | Install Size Change |
---|---|
🗑 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... | ⬇️ -1.9 kB |
📝 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... | ⬆️ 1.6 kB |
🗑 StripePayments.STPAPIClient.linkAccountSessions(endpoint,clientSe... | ⬇️ -1.2 kB |
📝 StripePayments.STPAPIClient.linkAccountSessions(endpoint,clientSe... | ⬆️ 936 B |
Other | ⬆️ 1.2 kB |
StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize
⚖️ Compare build
⏱️ Analyze build performance
Total install size change: ⬇️ 8.7 kB (-0.09%)
Total download size change: ⬇️ 5.0 kB (-0.15%)
Largest size changes
Item | Install Size Change |
---|---|
🗑 StripePaymentSheet.EmbeddedPaymentElement._paymentOption | ⬇️ -4.0 kB |
🗑 StripePaymentSheet.EmbeddedPaymentElement.makeView(configuration,... | ⬇️ -2.8 kB |
📝 StripePaymentSheet.EmbeddedPaymentElement.makeView(configuration,... | ⬆️ 2.6 kB |
🗑 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... | ⬇️ -1.9 kB |
📝 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... | ⬆️ 1.6 kB |
🛸 Powered by Emerge Tools
🚨 New dead code detected in this PR: FinancialConnectionsSentryClient.swift:9 warning: Imported module 'StripeCore' is unused
FinancialConnectionsSentryClient.swift:11 warning: Protocol 'FinancialConnectionsErrorReporter' is unused
FinancialConnectionsSentryClient.swift:15 warning: Class 'FinancialConnectionsSentryClient' is unused
SentryPayload.swift:11 warning: Struct 'SentryPayload' is unused
SentryStacktrace.swift:44 warning: Function 'capture(filePath:function:line:callsiteDepth:)' is unused Please remove the dead code before merging. If this is intentional, you can bypass this check by adding the label ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with |
96a02d7
to
a1de020
Compare
a1de020
to
e1ed083
Compare
Summary
Motivation
Testing
Changelog