Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PoC] Sentry client #4178

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[PoC] Sentry client #4178

wants to merge 1 commit into from

Conversation

mats-stripe
Copy link
Collaborator

Summary

Motivation

Testing

Changelog

@mats-stripe mats-stripe force-pushed the mats/sentry_client_poc branch from c79e86c to 96a02d7 Compare October 23, 2024 15:51
Copy link

emerge-tools bot commented Oct 23, 2024

5 builds increased size, 1 build decreased size

Name Version Download Change Install Change Approval
StripeSize
com.stripe.StripeSize
1.0 (1) 2.4 MB ⬆️ 621 B (0.03%) 7.8 MB ⬆️ 712 B N/A
StripeApplePaySize
com.stripe.StripeApplePaySize
1.0 (1) 438.0 kB ⬆️ 559 B (0.13%) 1.6 MB ⬆️ 2.4 kB (0.16%) N/A
StripeFinancialConnectionsSize
com.stripe.StripeFinancialConnectionsSize
1.0 (1) 1.3 MB ⬆️ 1.1 kB (0.08%) 4.3 MB ⬆️ 2.8 kB (0.07%) N/A
StripePaymentsSize
com.stripe.StripePaymentsSize
1.0 (1) 1.2 MB ⬇️ 262 B (-0.02%) 4.1 MB ⬆️ 710 B (0.02%) N/A
StripePaymentsUISize
com.stripe.StripePaymentsUISize
1.0 (1) 1.9 MB ⬆️ 578 B (0.03%) 6.3 MB ⬆️ 712 B (0.01%) N/A
StripePaymentSheetSize
com.stripe.StripePaymentSheetSize
1.0 (1) 3.4 MB ⬇️ 5.0 kB (-0.15%) 10.3 MB ⬇️ 8.7 kB (-0.09%) N/A

StripeSize 1.0 (1)
com.stripe.StripeSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 712 B
Total download size change: ⬆️ 621 B (0.03%)

Largest size changes

Item Install Size Change
🗑 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... ⬇️ -1.9 kB
📝 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... ⬆️ 1.6 kB
🗑 StripePayments.STPAPIClient.linkAccountSessions(endpoint,clientSe... ⬇️ -1.2 kB
📝 StripePayments.STPAPIClient.linkAccountSessions(endpoint,clientSe... ⬆️ 936 B
Other ⬆️ 1.2 kB
View Treemap

Image of diff

StripeApplePaySize 1.0 (1)
com.stripe.StripeApplePaySize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 2.4 kB (0.16%)
Total download size change: ⬆️ 559 B (0.13%)

Largest size changes

Item Install Size Change
Other ⬆️ 2.4 kB
View Treemap

Image of diff

StripeFinancialConnectionsSize 1.0 (1)
com.stripe.StripeFinancialConnectionsSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 2.8 kB (0.07%)
Total download size change: ⬆️ 1.1 kB (0.08%)

Largest size changes

Item Install Size Change
Other ⬆️ 2.8 kB
View Treemap

Image of diff

StripePaymentsSize 1.0 (1)
com.stripe.StripePaymentsSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 710 B (0.02%)
Total download size change: ⬇️ 262 B (-0.02%)

Largest size changes

Item Install Size Change
🗑 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... ⬇️ -1.9 kB
📝 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... ⬆️ 1.6 kB
🗑 StripePayments.STPAPIClient.linkAccountSessions(endpoint,clientSe... ⬇️ -1.2 kB
📝 StripePayments.STPAPIClient.linkAccountSessions(endpoint,clientSe... ⬆️ 936 B
Other ⬆️ 1.2 kB
View Treemap

Image of diff

StripePaymentsUISize 1.0 (1)
com.stripe.StripePaymentsUISize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬆️ 712 B (0.01%)
Total download size change: ⬆️ 578 B (0.03%)

Largest size changes

Item Install Size Change
🗑 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... ⬇️ -1.9 kB
📝 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... ⬆️ 1.6 kB
🗑 StripePayments.STPAPIClient.linkAccountSessions(endpoint,clientSe... ⬇️ -1.2 kB
📝 StripePayments.STPAPIClient.linkAccountSessions(endpoint,clientSe... ⬆️ 936 B
Other ⬆️ 1.2 kB
View Treemap

Image of diff

StripePaymentSheetSize 1.0 (1)
com.stripe.StripePaymentSheetSize

⚖️ Compare build
⏱️ Analyze build performance

Total install size change: ⬇️ 8.7 kB (-0.09%)
Total download size change: ⬇️ 5.0 kB (-0.15%)

Largest size changes

Item Install Size Change
🗑 StripePaymentSheet.EmbeddedPaymentElement._paymentOption ⬇️ -4.0 kB
🗑 StripePaymentSheet.EmbeddedPaymentElement.makeView(configuration,... ⬇️ -2.8 kB
📝 StripePaymentSheet.EmbeddedPaymentElement.makeView(configuration,... ⬆️ 2.6 kB
🗑 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... ⬇️ -1.9 kB
📝 StripePayments.STPAPIClient.createLinkAccountSessionForDeferredIn... ⬆️ 1.6 kB
View Treemap

Image of diff


🛸 Powered by Emerge Tools

Copy link

github-actions bot commented Oct 23, 2024

🚨 New dead code detected in this PR:

FinancialConnectionsSentryClient.swift:9 warning: Imported module 'StripeCore' is unused
FinancialConnectionsSentryClient.swift:11 warning: Protocol 'FinancialConnectionsErrorReporter' is unused
FinancialConnectionsSentryClient.swift:15 warning: Class 'FinancialConnectionsSentryClient' is unused
SentryPayload.swift:11 warning: Struct 'SentryPayload' is unused
SentryStacktrace.swift:44 warning: Function 'capture(filePath:function:line:callsiteDepth:)' is unused

Please remove the dead code before merging.

If this is intentional, you can bypass this check by adding the label skip dead code check to this PR.

ℹ️ If this comment appears to be left in error, double check that the flagged code is actually used and/or make sure your branch is up-to-date with master.

@mats-stripe mats-stripe force-pushed the mats/sentry_client_poc branch from 96a02d7 to a1de020 Compare October 23, 2024 19:12
@mats-stripe mats-stripe force-pushed the mats/sentry_client_poc branch from a1de020 to e1ed083 Compare October 23, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant