fix: RN 73 compatibility #1563
Open
fix: RN 73 compatibility #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
charliecruzan-stripe
requested changes
Nov 16, 2023
charliecruzan-stripe
previously approved these changes
Nov 17, 2023
huextrat
reviewed
Sep 10, 2024
Comment on lines
-1
to
-2
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
| package="com.reactnativestripesdk"> |
There was a problem hiding this comment.
For better backward compatibility, I recommend keeping package name here but lowering the gradle version to 7 if (agpVersion.tokenize('.')[0].toInteger() >= 7) {
This is what has been done for the most part on RN lib
|
@charliecruzan-stripe This is an old PR, but it would be useful to have it on a future version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new mandatory
android.namespaceconfig.Motivation
react-native-community/discussions-and-proposals#671
Testing
App builds with RN 73 and AGP 8
Documentation
Select one: