✨Fleet example changes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iván Álvarez <[email protected]>
sttts
reviewed
May 26, 2024
| return nil | ||
| } | ||
| cm.engagedClustersLock.RUnlock() |
There was a problem hiding this comment.
great find! but don't we need both? RUnlock on return, and RUnlock for the else case?
There was a problem hiding this comment.
Yes! I missed that. I have also update the fleet example with the same error here.
sttts
reviewed
May 26, 2024
examples/fleet/main.go
Outdated
|
|
||
| // Retrieve the pod from the cluster. | ||
| pod := &corev1.Pod{} | ||
| if err := client.Get(ctx, req.NamespacedName, pod); err != nil { | ||
| return reconcile.Result{}, err | ||
| } | ||
| log.Info("Reconciling pod", "name", pod.Name, "uuid", pod.UID) | ||
| log.Info(fmt.Sprintf("Retrieved pod %s:>%s/%s", cl.Name(), pod.Namespace, pod.Name)) |
There was a problem hiding this comment.
this is an anti-pattern for structural logging. Just add "ns", pod.Namespace.
sttts
reviewed
May 26, 2024
Co-authored-by: Dr. Stefan Schimanski <[email protected]>
Signed-off-by: Iván Álvarez <[email protected]>
…ntroller-runtime into sttts-cluster-support
Signed-off-by: Iván Álvarez <[email protected]>
|
Perfect. Merging. Btw, I want to come back to the PR and the design proposal soonish. Thanks for trying it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @sttts,
First at all, let me please put some context about this PR.
Starting from the (amazing!!!) changes of your PR, my goal was to create an operator that watch the changes at many clusters. I was able to create the POC, but I have to add some small changes reflected in this PR.
During my tests I was not able to
engagea new cluster as the code was always hung at line627: cm.engagedClustersLock.Lock(), as the lock was neverRUnlock(ed).fleettest.If this changes make sense for you, feel free to merge this PR or add them directly in your branch.
Note: I also try to run
make testto validate these code changes, but I have some compiler errors.I have not found any reference in the code to
cluster.WatchEvent. If you could provide to me some context about this error, I will be happy to review it.Regards,
Iván