-
Notifications
You must be signed in to change notification settings - Fork 35
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
REQUEST_URI env is not actually part of the Rack Spec (https://github.com/rack/rack/blob/main/SPEC.rdoc), so relying on its values is highly dubious. And as seen in #34, the values provided in REQUEST_URI can differ between application servers, notably with Webrick including the host name in REQUEST_URI whereas Puma does not. We should be able to function perfectly fine with just the PATH_INFO. Only tests that failed after removing REQUEST_URI handling were the ones that explicitly tested REQUEST_URI handling.
- Loading branch information
Showing
2 changed files
with
5 additions
and
71 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters