feat: move and fix adhoc tests #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ingomueller-net
force-pushed
the
move-adhoc
branch
from
5e6c9b6 to
cecb18e
Compare
.github/workflows/test.yml
Outdated
| @@ -81,3 +81,7 @@ jobs: | |||
| - name: Run Ibis expression tests | |||
| if: ${{ matrix.producer == 'ibis' }} | |||
| run: pytest substrait_consumer/functional/queries/ibis_expressions/ | |||
|
|
|||
| - name: Run Ibis expression tests | |||
There was a problem hiding this comment.
This is the same name as above -- should it be different?
There was a problem hiding this comment.
Yes, good catch.
This PR moves the adhoc tests to a more top-level directory, fixes several problems, and adds a target to CI. Signed-off-by: Ingo Müller <[email protected]>
ingomueller-net
force-pushed
the
move-adhoc
branch
from
cecb18e to
a8ff7b4
Compare
EpsilonPrime
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the adhoc tests to a more top-level directory, fixes several problems, and adds a target to CI.