Skip to content

Commit

Permalink
Merge branch 'bugfix/#73-fixme-code-comment' into 'develop'
Browse files Browse the repository at this point in the history
Refactor/#73: Addressing fixme comments.

See merge request subugoe/emo/Qviewer!78
  • Loading branch information
mdindigala committed Oct 13, 2020
2 parents 490cf49 + fd1f696 commit a10478b
Showing 1 changed file with 9 additions and 5 deletions.
14 changes: 9 additions & 5 deletions src/components/content.vue
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,11 @@
</div>
</div>

<!-- FIXME: remove inline style -->
<!-- FIXME: Current implementations in most browsers will remove from the accessibility tree any element with a display value of contents (but descendants will remain). This will cause the element itself to no longer be announced by screen reading technology. https://developer.mozilla.org/en-US/docs/Web/CSS/display#Accessibility_concerns -->
<div class="row" style="display: contents;">
<!-- FIXME: remove inline style -->
<div class="row">
<div
class="scroll-panel"
ref="contentsize"
:id="nodeid"
:style="`font-size: ${fontsize}px`"
v-html="content"
/>
</div>
Expand All @@ -60,6 +57,11 @@ export default {
sequenceindex: 0,
};
},
watch: {
fontsize() {
this.$refs.contentsize.style.fontSize = `${this.fontsize}px`;
},
},
methods: {
decrease() {
const min = 8;
Expand Down Expand Up @@ -96,6 +98,8 @@ export default {
this.content = await this.request(this.contenturl, 'text').then((data) => data);
},
mounted() {
this.$refs.contentsize.style.fontSize = `${this.fontsize}px`;
this.$root.$on('update-sequence-index', (index) => {
if (this.manifests[index].support) {
this.manifests[index].support.map(this.getSupport);
Expand Down

0 comments on commit a10478b

Please sign in to comment.