Allocate VariantItems colors after annotations are loaded for each item #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2024 15:36
… variants and show the list correctly
orlinmalkja
force-pushed
the
bug-switching-items-colors-init
branch
from
345c7f4 to
0ca8023
Compare
|
@paulpestov please go ahead reviewing this PR |
paulpestov
reviewed
Oct 28, 2024
src/utils/variants.js
Outdated
| import { getItemColorBasedOnIndex } from '@/utils/color'; | ||
|
|
||
|
|
||
| export function allocateWitnessColorInVariantItem() { |
There was a problem hiding this comment.
Since you are using many things from the annotation store + this function is only used once, you can move idrectory to the annotation store itself.
|
I moved the allocateWitnessColorInVariantItem() function to annotation Store! |
paulpestov
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: navigate to item 182b variants tab opened (?tido=m20_i0_p0.0-1.0-2.0-3.2) and switch to 183a (tido=m20_i1_p0.0-1.0-2.0-3.2 with example data → error with colors
Closes #508