Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch text views - Use OpenSeaDragon for the image #543

Merged
merged 44 commits into from
Jan 8, 2025
Merged

Switch text views - Use OpenSeaDragon for the image #543

merged 44 commits into from
Jan 8, 2025

Conversation

orlinmalkja
Copy link
Contributor

This PR aims to fulfill the following requirements:

  • Use a Zustand store to store the content of the current visible panels. The data for one panel is stored as a key-value pair.
  • Switch between text views when clicking the respective icon.
  • Use Open SeaDragon for the image and add the image action buttons
  • Open a popover on click

orlinmalkja added 30 commits December 18, 2024 16:31
chore: use 'preserve' for 'jsx' attribute in config, to get rid of 4 …
46f6be2 
…'Cannot use JSX unless the '--jsx' flag is provided'
chore: set up shadcn
b515ffe
wip(content Store): add an initial version of content Store
74776ea
wip (texts in contentStore): add texts in item of ContentStore
cf7768f
wip (refactor content types toggle): control content types toggle in …
a577b9a 
…PanelCentralContent
fix (content types toggle): use the state 't' for the activeContentTy…
5648644 
…peIndex
chore (content types toggle): minor
48a7878
chore(content types toggle): add error handling in Content Types toggle
3ddd83c
feat (switch text views): add the split image-text view
b4f8170
feat(switch text views): add image view only as a simple image
3c726fe
feat(image view): represent image as OpenSeaDragon and add the existi…
6f169b5 
…ng image actions
fix (Open Sea Dragon): add unique id for the action buttons which is …
b78c47c 
…the same as the opened panel index
fix(Open Sea Dragon Viewer): set a unique 'id' for each viewer
213bcc4
refactor(Panel): remove text from Panel
536e254
refactor(Config Provider): remove openedPanels
ae16735
fix (init Data): init data synchronously for each panel in config: fi…
36eaf42 
…rstly store the data in store and then show the panels
refactor(Content Types Toggle): add content types in store
e59399e
fix (Content Types Toggle): add the necessary change in Content Store
2d270a7
fix (Split View): add the image as Open Sea Dragon Image Viewer
4ced221
style: clean code in ImageView
a1d6e22
style: clean code in PanelCentralContent
56839ef
style: clean code in SplitView
9279868
style: clean code in TextView
e2c7f96
style: clean code in TextViewOne
54a3709
fix (Content Types Toggle): improve the design of the buttons
fc4ac59
style: clean Panel component
34c2e0b
style: clean PanelsTopBar
cf5ab3f
style: clean TextViewsToggle and utils/icons
54998df
style: add minor changes
3dbbfe6
refactor (ImageActionButtons): add typescript interface for ImageAction
e125a52
@orlinmalkja orlinmalkja requested a review from paulpestov January 6, 2025 16:37
@orlinmalkja orlinmalkja self-assigned this Jan 6, 2025
paulpestov
paulpestov reviewed Jan 6, 2025
View reviewed changes
src/components/panel/central-content/ImageView.tsx Outdated Show resolved Hide resolved
src/components/panel/central-content/SplitView.tsx Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
src/components/panel/Panel.tsx Outdated Show resolved Hide resolved
src/store/ContentStore.tsx Outdated Show resolved Hide resolved
src/store/ContentStore.tsx Outdated Show resolved Hide resolved
src/types.d.ts Outdated Show resolved Hide resolved
src/types.d.ts Outdated Show resolved Hide resolved
src/components/PanelsWrapper.tsx Outdated Show resolved Hide resolved
@orlinmalkja
Copy link
Contributor Author

@paulpestov I think that I undertook all the changes that you suggested!

@orlinmalkja orlinmalkja merged commit d11c8fc into next Jan 8, 2025
2 checks passed
@orlinmalkja orlinmalkja deleted the v5-working-app branch January 8, 2025 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulpestov paulpestov paulpestov approved these changes

Assignees

@orlinmalkja orlinmalkja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orlinmalkja @paulpestov