Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flexible order of metadata items #551

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

orlinmalkja
Copy link
Contributor

In this PR I aim to add the feature of configuring the order of metadata based on:

  • Document type: Sorting the metadata on a document level based on a user's defined order of document types: i.e ["collection", "item", "manifest"]
  • Metadata item: Sort the metadata within each document. User can provide the desired order of the metadata keys himself.

@orlinmalkja orlinmalkja self-assigned this Jan 15, 2025
import { useToggle } from '@vueuse/core/index';
import { isDark } from '@/utils/is-dark';

import { createApp, h } from 'vue'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why all the semicolon changes? In TIDO v4 we actually have used semicolons, how is ESLint is passing them through?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I have added a file src/.prettierrc.json which has the rules: 'semicol': false -> when saving the file it removes the semicolons. Using prettier I could improve my code style in vscode.

Copy link
Collaborator

@paulpestov paulpestov Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not using Prettier in TIDO. So if we would, we needed a package.json entry. In any way such changes make it harder to review a PR. I would appreciate if we could stick to change only that parts of code that actually bring value to the remaining tasks in TIDO 4.

Also I am sure that VSCode can be configured with our current ESList setup.

@@ -72,6 +72,26 @@
all: true,
},
citationKey: "Citation",
orderDocuments: ["manifest", "collection", "item"],
orderCollectionMetadata: [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I stated in the issue comment, I think the "..Metadata" suffix is not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants