-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flexible order of metadata items #551
base: develop
Are you sure you want to change the base?
Conversation
import { useToggle } from '@vueuse/core/index'; | ||
import { isDark } from '@/utils/is-dark'; | ||
|
||
import { createApp, h } from 'vue' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why all the semicolon changes? In TIDO v4 we actually have used semicolons, how is ESLint is passing them through?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because I have added a file src/.prettierrc.json
which has the rules: 'semicol': false -> when saving the file it removes the semicolons. Using prettier I could improve my code style in vscode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are not using Prettier in TIDO. So if we would, we needed a package.json entry. In any way such changes make it harder to review a PR. I would appreciate if we could stick to change only that parts of code that actually bring value to the remaining tasks in TIDO 4.
Also I am sure that VSCode can be configured with our current ESList setup.
@@ -72,6 +72,26 @@ | |||
all: true, | |||
}, | |||
citationKey: "Citation", | |||
orderDocuments: ["manifest", "collection", "item"], | |||
orderCollectionMetadata: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I stated in the issue comment, I think the "..Metadata" suffix is not needed.
In this PR I aim to add the feature of configuring the order of metadata based on: