refactor: the 'base' and a few 'header' components #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orlinmalkja
commented
May 17, 2024
| const props = defineProps(['name']); | ||
| //const props = defineProps(['name']); | ||
| export interface Props { | ||
| name: string |
There was a problem hiding this comment.
Should I set the type of the name to be part of a list of names, or just let it string ?
There was a problem hiding this comment.
string should be enough
orlinmalkja
commented
May 17, 2024
|
|
||
| const show = computed(() => config.value?.header?.show); | ||
| const manifests = computed(() => store.getters['contents/manifests']); | ||
| const store = useStore(); | ||
| const config = computed(() => store.getters['config/config']); |
There was a problem hiding this comment.
Is it necessary to create an interface and assign it as a type to 'config' ?
paulpestov
reviewed
May 21, 2024
src/components/base/BaseIcon.vue
Outdated
| import { getIcon } from '@/utils/icons'; | ||
|
|
||
| const props = defineProps(['name']); | ||
| //const props = defineProps(['name']); |
paulpestov
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.