Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix; ubuntu 24 toolchain #1900

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

CreeptoGengar
Copy link

@CreeptoGengar CreeptoGengar commented Dec 26, 2024

Description

This pull request adds support for Ubuntu 24.04 in the toolchain installation process. Key changes include:

  • Added detection and handling of Ubuntu 24.04 in toolchain.rs to ensure compatibility with glibc requirements.
  • Introduced specific compiler flags for static linking on Ubuntu 24.04.
  • Updated DEVELOPMENT.md with documentation for the Ubuntu 24.04 support process.
  • Added tests for Ubuntu 24.04 toolchain installation in toolchain_tests.rs.

Motivation

Ubuntu 24.04 introduces new compatibility challenges with glibc versions, requiring static linking in toolchain installations. This change aims to enhance the user experience for developers using this version of Ubuntu.

Solution

  • The toolchain.rs module now detects the Ubuntu version and applies specific compiler flags for compatibility.
  • The installation process uses static linking when Ubuntu 24.04 is detected.
  • Additional error handling and logging were added for robustness.
  • Tests were created to verify functionality on Ubuntu 24.04.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes (N/A)

Additional Notes

This PR includes:

  • 3 commits
  • 3 file changes
  • 46 additions and 0 deletions

Fixes #1895

Allow edits from maintainers.

This contribution adheres to the project's contributing guidelines and security policies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo prove install-toolchain segfaults
1 participant