Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: v4.0.1 #1941

Merged
merged 14 commits into from
Jan 17, 2025
Merged

feat: v4.0.1 #1941

merged 14 commits into from
Jan 17, 2025

Conversation

nhtyy
Copy link
Collaborator

@nhtyy nhtyy commented Jan 16, 2025 •
edited
Loading

  • Includes a warning message when using cargo prove build --elf-name without a corresponding --output-directory
  • Includes a fix for programs failing to build on host that depend on sp1-zkvm & sp1-lib
  • Bumps gnark docker test storage
  • Adds docs that sp1up always installs and the newest version and you should use -C in ci
  • Adds docs about potential toolchain issues with old versions of sp1-build
  • Better panic messages on read / read_vec
  • Fixes an eror when installing the cli from crates
  • Updates the toolchain tag, the new version supports old libc versions on x86

@nhtyy nhtyy changed the title v4.0.1 feat: v4.0.1 Jan 16, 2025
@nhtyy
Copy link
Collaborator Author

nhtyy commented Jan 16, 2025

Missing version bump, do not merge until thats done.

ratankaliani
ratankaliani previously approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after the inclusion of 4.0.1 tag bump.

@ratankaliani ratankaliani dismissed their stale review January 17, 2025 19:19

not all changes included yet

ratankaliani
ratankaliani reviewed Jan 17, 2025
View reviewed changes
.github/workflows/book.yml Outdated
@@ -46,7 +46,7 @@ jobs:

deploy:
# Only deploy if a push to main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: update comment

nhtyy
nhtyy commented Jan 17, 2025
View reviewed changes
.github/workflows/book.yml Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Jan 17, 2025
View reviewed changes
crates/cli/src/lib.rs Outdated Show resolved Hide resolved
ratankaliani
ratankaliani approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@ratankaliani ratankaliani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small comment

@nhtyy @github-actions
Update crates/cli/src/lib.rs
1b065ad 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@nhtyy nhtyy merged commit dae15e9 into main Jan 17, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ratankaliani ratankaliani ratankaliani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nhtyy @ratankaliani