Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Float icon back to top #605

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Devmoni
Copy link
Contributor

@Devmoni Devmoni commented Dec 22, 2024

Description

This PR updates the visibility behavior of the 'Back to Top' button. Instead of being only in the footer, the button now appears when the user scrolls down the page by 30%. This change improves the user experience by providing quicker access to the top of the page.

@quozl
Copy link
Contributor

quozl commented Dec 22, 2024

Is this feature also available in later versions of Bootstrap and Airspace? If so would it be better to upgrade?

@Devmoni
Copy link
Contributor Author

Devmoni commented Dec 23, 2024

This feature is implemented using only JavaScript and simple CSS, ensuring that it does not alter any core CSS of Bootstrap and Airspace.

I believe this can be useful since the site is quite long, helping users reach the top with just one click.

@quozl
Copy link
Contributor

quozl commented Dec 23, 2024

You didn't answer my question. I've checked, and I can find nothing in either Bootstrap or Airspace latest releases to indicate that the feature is provided by either library.

@Devmoni
Copy link
Contributor Author

Devmoni commented Dec 23, 2024

You're correct that Bootstrap and Airspace don't offer this feature by default.

But as for whether it would be better to upgrade,
Currently, the 'Return to Top' button is placed in the footer, but positioning it as a fixed button in the bottom-right corner would make it more accessible as users scroll.
A fixed button provides immediate visibility and usability, allowing users to return to the top without needing to scroll back down to the footer

@quozl
Copy link
Contributor

quozl commented Dec 23, 2024

Thanks. My questions were about implementation and retaining our upgrade paths. I am surprised this feature isn't in the libraries or themes we are using, but we are behind by a fair bit.

You do keep advocating afresh for your feature. These can go into the commit message rather than the pull request.

(For myself, I find return to top buttons visually distracting and waste horizontal space at the lower edge of the view port. I already know how to scroll to top, and don't need no web site to give me again a feature the browser already has. Sure, there are people who don't know how to run their browser, but we're not an online gambling site. We depend on prior learning to deliver the message that learning is critical for those in the care of the reader.).

@pikurasa please review; is this feature something you want?

@quozl
Copy link
Contributor

quozl commented Dec 24, 2024

Please resolve conflicts.

The button now appears when the user has scrolled 30% down the page.
Previously, it was only visible in the footer.
@Devmoni
Copy link
Contributor Author

Devmoni commented Dec 25, 2024

I have resolved the conflicts as requested.

@quozl quozl requested a review from pikurasa December 25, 2024 20:58
@quozl quozl changed the title Update Back to Top Button Visibility Float icon back to top Dec 25, 2024
@quozl
Copy link
Contributor

quozl commented Dec 26, 2024

#612 does replace or augment this pull request? If replace, please close this one. Thanks.

@Devmoni
Copy link
Contributor Author

Devmoni commented Dec 27, 2024

No, as I separated #612 since it’s just a suggestion for the existing banner.
Thanks...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants