-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Float icon back to top #605
base: master
Are you sure you want to change the base?
Conversation
Is this feature also available in later versions of Bootstrap and Airspace? If so would it be better to upgrade? |
This feature is implemented using only JavaScript and simple CSS, ensuring that it does not alter any core CSS of Bootstrap and Airspace. I believe this can be useful since the site is quite long, helping users reach the top with just one click. |
You didn't answer my question. I've checked, and I can find nothing in either Bootstrap or Airspace latest releases to indicate that the feature is provided by either library. |
You're correct that Bootstrap and Airspace don't offer this feature by default. But as for whether it would be better to upgrade, |
Thanks. My questions were about implementation and retaining our upgrade paths. I am surprised this feature isn't in the libraries or themes we are using, but we are behind by a fair bit. You do keep advocating afresh for your feature. These can go into the commit message rather than the pull request. (For myself, I find return to top buttons visually distracting and waste horizontal space at the lower edge of the view port. I already know how to scroll to top, and don't need no web site to give me again a feature the browser already has. Sure, there are people who don't know how to run their browser, but we're not an online gambling site. We depend on prior learning to deliver the message that learning is critical for those in the care of the reader.). @pikurasa please review; is this feature something you want? |
Please resolve conflicts. |
The button now appears when the user has scrolled 30% down the page. Previously, it was only visible in the footer.
I have resolved the conflicts as requested. |
#612 does replace or augment this pull request? If replace, please close this one. Thanks. |
No, as I separated #612 since it’s just a suggestion for the existing banner. |
Description
This PR updates the visibility behavior of the 'Back to Top' button. Instead of being only in the footer, the button now appears when the user scrolls down the page by 30%. This change improves the user experience by providing quicker access to the top of the page.