Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Feed to support CSS style sheet specification #23

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

meyercr
Copy link

@meyercr meyercr commented Jul 24, 2017

Hello Suin,
Thank you for your useful library.
Are you interested in supporting CSS Style sheets for RSS feeds? This change adds support for including a Style sheet in the XML.

$feed->addStyle("", "<optional media specification - defaults to screen>")

Thank you,
Craig

@suin
Copy link
Owner

suin commented Jul 25, 2017

@meyercr Thank you for PR😆 CSS style sheets for RSS sounds interesting! I would like to merge your great work. Could you brush up your cool changes?

  1. Could you remove debug code for production?
  2. Could you follow camel case naming for style consistency? For example, feedStyles would be much consistent than feed_styles.

Thank you

@meyercr
Copy link
Author

meyercr commented Jul 25, 2017

Thank you for your interest.
I have removed the debug() code, I had forgotten in was there.
And I have used camelCase as you suggested.
I have pushed the differences up to GitHub, do I did to resubmit the Pull Request?

@peter279k
Copy link

peter279k commented May 30, 2018

Is anyone concern this PR?
This PR is great and it's need to be reviewed and merged 👍 .

@jaspal747
Copy link

Suin.. do you mind merging this?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants