-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cluster and user name conflict on add kubeconfig with same context cluster and user #1048
Conversation
…xt cluster and user
The Label Bot has predicted the following:
|
Hey there! Let's fix that unit test! |
If use rand generate suffixe instead of hash, then I think we need to modify the test functions. So what do you think. |
Of course. |
…xt cluster and user
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
4387263 | Triggered | Generic High Entropy Secret | 050e806 | cmd/add_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Updated. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1048 +/- ##
==========================================
- Coverage 20.26% 19.56% -0.70%
==========================================
Files 21 21
Lines 2615 2647 +32
==========================================
- Hits 530 518 -12
- Misses 2038 2075 +37
- Partials 47 54 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for your valuable contribution to this project! Your work is greatly appreciated. 🎆
@all-contributors please add @poneding for code |
I've put up a pull request to add @poneding! 🎉 |
Description
See issue #1047 and Files changed.
Related Issue
resolves #1047
Type of Change
Checklist
make build
andmake test
commands.make doc-gen
to generate new documentation.