Escape minus char in regular expressions #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlocati
force-pushed
the
fix-minus-not-range-in-regex
branch
from
73104ac to
3f19049
Compare
|
Still an issue over a year later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PHP 7.3, PCRE2 (the library that parses regular expressions) has been upgraded to version 10.32.
It seems that this new version of PCRE is a bit more picky when parsing regular expressions.
For example,
/^[\w-:]+$is not accepted anymore, we have this error (see https://3v4l.org/vD5O2):The reason?
-is used to represent range of characters when in square brackets (for example:[A-Z]represents a character fromAtoZ).And PCRE now interprets
[\w-:]asany character from \w to :, which doesn't make sense (so the error is thrown).The solution? Just escape
-with\to tell PCRE that we actually want the character-, and not a range of characters.