Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds markdown image loading #6

Merged
merged 2 commits into from
Apr 4, 2020
Merged

Adds markdown image loading #6

merged 2 commits into from
Apr 4, 2020

Conversation

pietgeursen
Copy link
Member

@pietgeursen pietgeursen commented Dec 22, 2019 •
edited
Loading

  • related to this pr in the go code
  • image loading is kinda "one shot", if the server had the image at that particular moment, you get it, if not, it's not displayed. This comes from the go side. If we can fix it in go then we'll have async image loading which would be way better.
  • gifs don't seem to animate

Screenshot_20191222-161029

@pietgeursen pietgeursen merged commit cfc826b into master Apr 4, 2020
@pietgeursen pietgeursen deleted the markdown_image_loading branch April 4, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pietgeursen