typescript profile parser #124
Conversation
TheEdward162
force-pushed
the
feat/typescript_profile_parser
branch
from
87f787a to
fe717f4
Compare
* rename Comlink language parser to make room for TypeScript parser integration
TheEdward162
force-pushed
the
feat/typescript_profile_parser
branch
from
fe717f4 to
78eb7a3
Compare
TheEdward162
force-pushed
the
feat/typescript_profile_parser
branch
from
78eb7a3 to
ac6fb58
Compare
* create comlink_wasm package * create wasm_abi package by extracting the abi part from host_to_core_std, making it reusable
* to allow lower-level sharing of common/lib
* copy from language-server repo * change to use comlink wasm
* We mainly use two forms: `UseCase` as a camel cased variant and `usecase` as snake case variant. This is already inconsistent but changing the snake case variant would be a big breaking change. * This commit changes usages of `Usecase` into `UseCase`
|
This PR got a little fat because I included some OCD changes, like consolidating names/variables named Usecase to UseCase. I think going commit-by-commit might help with review. Either way, it can also be reviewed by trying it out with the vscode extension as I posted in Slack. |
There was a problem hiding this comment.
Well lets be honest, I tried to read it and understand, but there are places I am not sure. Since it seems to work, I don't want to block this PR anymore.
Searching "things" in TypesScript AST is 🤯, but most likely, because I didn't get much used to AST biome parser produces.
few nitpicks:
packages/comlink_language_server/src/parser/index.tsseems to mix tabs and spaces- found missing
;
praises:
- I like we have now
wasm_abias separate crate - Comlink tooling in one crate
| @@ -21,6 +23,7 @@ function strace<A extends unknown[], R>(name: string, fn: Fn<A, R>, asyncify: As | |||
| return result; | |||
| } | |||
| } | |||
| // @ts-ignore ignore unused function | |||
There was a problem hiding this comment.
I left these thinking it can come in handy in two cases:
- as a documentation of how to work with the ABI from TypeScript
- in case you are debugging your code by monkey-patching it, then these can come in handy since they will be in the dist already. However I did not quite realize that bundlers will probably notice these are unused and remove them.
I think we can safely remove them.
| @@ -37,6 +40,7 @@ function join_abi_result(lower: number, upper: number): number { | |||
|
|
|||
| return l | u; | |||
| } | |||
| // @ts-ignore ignore unused funtion | |||
| Some((example, spans)) | ||
| } | ||
|
|
||
| fn parse_example_element_value(&mut self, expr: AnyJsExpression) -> JsonValue { |
There was a problem hiding this comment.
I don't even remember we allowed to have expressions in example values.
There was a problem hiding this comment.
Even literals are wrapped in expression node when in expression position. Since examples are of the form:
const examples: UseCaseName['examples'] = [
{ input: 1, result: 2 }
]Then all of [], {}, 1 and 2 are something like Expression(Literal) nodes in the tree.
tracking work on typescript profile parser