Feat/multiple securities #141
Conversation
| @@ -11,7 +11,8 @@ export type FetchOptions = { | |||
| headers?: MultiMap, | |||
| query?: MultiMap, | |||
| body?: AnyValue, | |||
| security?: string, | |||
| /** Security configs to apply to this request. Specifying a string is equal to using `first-valid` */ | |||
| security?: string | { kind: 'first-valid', ids: string[] } | { kind: 'all', ids: string[] }, | |||
There was a problem hiding this comment.
@Jakub-Vacek @janhalama what do you think about this API? Most importantly won't it be trouble for Edgar?
There was a problem hiding this comment.
I think this will be fine for newer version(s) of Edgar where we use stronger models. We will have to explain LLM difference between first-valid and all and nudge him towards first valid
:)
There was a problem hiding this comment.
Looks good to me.
This is my workaround for using multiple security schemes with Pipedrive. It will be much easier to implement it now including the fallback to next security scheme in case of 401 error.
There was a problem hiding this comment.
As it is implemented now, it will just resolve first security. Not do call and try another.
For Pipedrive it was migration from api_key to oauth bearerToken (btw that naming "consistency" 🙈). But in general how often users have both configured?
* Implement support for multiple securities * The map can pick between `first-valid` and `all` kinds, which affect whether all specified securities are applied or just the first valid
* move "legacy" http security normalization to map-std, so that core input surface doesn't increase
TheEdward162
force-pushed
the
feat/multiple-securities
branch
from
99cbca0 to
32c0743
Compare
Description
Adds support for specifying multiple securities in a map.
Motivation and Context
There's been a request to be able to specify in map that I want to use first valid security from a given list. There's also been a request before to allow applying multiple securities onto one request. This PR introduces a backwards-compatible way to do both.
Types of changes