Show error message for incompatible beatmap version instead of crashing #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No need to commit the package-lock.json |
|
Cool. Thanks. I'm gonna hold on merging this to see if we can fix #186 first quickly. If not we might need to revert to an A-Frame 1.1.0 commit and want to keep history simple. |
|
This needs rebase |
1 similar comment
|
This needs rebase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the beatmaps are version 3 with different object keys and added features. This PR shows an error message when these songs are selected instead of crashing. I didn't see a way to grab/filter compatible versions only. Sometimes the beatmap versions were different from the info object, so I scanned for the version in beatmap instead.