-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to opt-out of use:enhance for forms #13250
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 7ab5852 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-kit-13250-svelte.vercel.app/ this is an automated message |
@@ -117,6 +117,11 @@ export function enhance(form_element, submit = () => {}) { | |||
: clone(form_element).method; | |||
if (method !== 'post') return; | |||
|
|||
const skip = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can reuse the get_router_options
function to get the reload option state
kit/packages/kit/src/runtime/client/utils.js
Line 151 in 9a4a411
export function get_router_options(element) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also thought about reusing it but decided against it as I think it could result in surprising and hard to debug code if the parents of two elements (the form and the button) are inspected for the reload option.
Instead I reused the underlying functions and logic.
fix #13180
I reused the
data-sveltekit-reload
attribute to opt-out ofuse:enhance
. The attribute can be present either on the form element or the form button.More details of the reasoning in the linked issue but tl;dr: I need to post to an endpoint in a new tab from the same form that is used for formactions and
use:enhance
.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. Changesets that add features should beminor
and those that fix bugs should bepatch
. Please prefix changeset messages withfeat:
,fix:
, orchore:
.Edits