Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to opt-out of use:enhance for forms #13250

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fehnomenal
Copy link
Contributor

fix #13180

I reused the data-sveltekit-reload attribute to opt-out of use:enhance. The attribute can be present either on the form element or the form button.

More details of the reasoning in the linked issue but tl;dr: I need to post to an endpoint in a new tab from the same form that is used for formactions and use:enhance.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Dec 28, 2024

🦋 Changeset detected

Latest commit: 7ab5852

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13250-svelte.vercel.app/

this is an automated message

@eltigerchino eltigerchino changed the title feat: allow to out-out of use:enhance for forms feat: allow to opt-out of use:enhance for forms Dec 30, 2024
@eltigerchino eltigerchino added the feature / enhancement New feature or request label Dec 30, 2024
@@ -117,6 +117,11 @@ export function enhance(form_element, submit = () => {}) {
: clone(form_element).method;
if (method !== 'post') return;

const skip =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can reuse the get_router_options function to get the reload option state

export function get_router_options(element) {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also thought about reusing it but decided against it as I think it could result in surprising and hard to debug code if the parents of two elements (the form and the button) are inspected for the reload option.

Instead I reused the underlying functions and logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature / enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow skipping use:enhance with data-sveltekit-reload
3 participants