fix(site-kit): respect system theme preference #1076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #703.
Problem
system
preference isn't respected when the user's system preference changes before returning to the site.Issue reproduction:
system
)This is a common occurrence for me since my system preference is 'auto', and when I return to the site in the evening (system theme is 'dark'), svelte.dev renders in light mode.
Solution
When loading the site with
system
as the set theme, ensure the appropriate system theme gets applied at startup.Unfortunately, there is a flash during the system theme toggle recovery. I tried this alternative approach, but it's not any faster:
I suppose replacing JS-based class-switching logic to CSS-based media queries or
light-dark()
would be an enhancement for another day.A note on documentation PRs
If this is a documentation PR (i.e. changing content within
apps/svelte.dev/content/docs
), then this is the wrong repository to make those changes. The content in this folder is synced from other repositories. Therefore, these changes should be made in their respective repositories (at https://github.com/sveltejs/svelte or https://github.com/sveltejs/kit, or example).Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.