-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correctly highlight sources reassigned inside trace
#14811
Conversation
🦋 Changeset detectedLatest commit: 83473d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
preview: https://svelte-dev-git-preview-svelte-14811-svelte.vercel.app/ this is an automated message |
|
@paoloricciuti hello. I haven't had the time to help out with your request in the other PR, which got closed. I see you opened this new one. Is this new one working on my code? If not, I'll try to check it out today. |
It should...maybe if you have some time check out the result to see if it make sense for you too |
The code looks good to me, can you share a video or screenshots with the before and after too please? |
Sure will do in a bit |
@trueadm here it is BeforeAfter |
Alternative to #14801
Closes #14794
Closes #14869
This fixes two bugs: one where the sources reassigned in the trace where not properly highlighted and another where the value logged was not correct (it showed the value of the source after the reassignment).
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.packages/svelte/src
, add a changeset (npx changeset
).Tests and linting
pnpm test
and lint the project withpnpm lint